From: Tuncer Ayaz Date: Fri, 03 Oct 2008 20:18:55 GMT Subject: Re: [PATCH] Fix argument handling for fetch-pack call when stdout is connected and -q/--quiet is supplied. Message-ID: <4ac8254d0810031318j3e0f326ewc4bf250c51681670@mail.gmail.com> In-Reply-To: On Fri, Oct 3, 2008 at 9:50 PM, Daniel Barkalow wrote: > On Fri, 3 Oct 2008, Tuncer Ayaz wrote: >> diff --git a/transport.c b/transport.c >> index 71433d9..1f24011 100644 >> --- a/transport.c >> +++ b/transport.c >> @@ -644,7 +644,7 @@ static int fetch_refs_via_pack(struct transport *transport, >> args.include_tag = data->followtags; >> args.verbose = (transport->verbose > 0); >> args.quiet = args.no_progress = (transport->verbose < 0); >> - args.no_progress = !isatty(1); >> + args.no_progress = args.quiet || !isatty(1); > > If you're doing that, remove the "args.no_progress =" from the previous > line, which was there to have that effect (but not so clearly). Aside from > that, it looks good to me. > Thanks Daniel, that makes a lot of sense. Signed-off-by: Tuncer Ayaz --- transport.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/transport.c b/transport.c index 71433d9..35cac44 100644 --- a/transport.c +++ b/transport.c @@ -643,8 +643,8 @@ static int fetch_refs_via_pack(struct transport *transport, args.use_thin_pack = data->thin; args.include_tag = data->followtags; args.verbose = (transport->verbose > 0); - args.quiet = args.no_progress = (transport->verbose < 0); - args.no_progress = !isatty(1); + args.quiet = (transport->verbose < 0); + args.no_progress = args.quiet || !isatty(1); args.depth = data->depth; for (i = 0; i < nr_heads; i++) -- 1.6.0.2