From: Rasmus Villemoes <rv@rasmusvillemoes.dk>
Date: Thu, 17 Sep 2020 08:20:03 GMT
Subject: approximate_object_count_valid never set?
Message-ID: <4a018cb9-da40-a98f-a1b9-73be30ae79ec@rasmusvillemoes.dk>

Hi,

While poking around the code, I noticed that it seems
->approximate_object_count_valid is never set to 1, and it never has
been, not even back when it was a global variable. So perhaps it can
just be removed and the logic depending on it simplified? Or am I
missing some preprocessor trickery.

Nobody seems to have noticed the lack of caching - and actually setting
it to 1 after the count has been computed might be a little dangerous
unless one takes care to invalidate the cache anywhere that might be
relevant.

Rasmus