From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Thu, 12 Jul 2012 12:15:30 GMT
Subject: Re: [PATCH 3/6] t4012: Actually quote the sed script
Message-ID: <4FFEBFE2.5030206@in.waw.pl>
In-Reply-To: <20120711221241.GA21342@akuma>

On 07/12/2012 12:12 AM, Alexander Strasser wrote:
> The nested quoting is not needed in this cases, thus the previous
> version did work just fine. Never the less the usage is misleading,
> so just achieve nested quoting by using double quotes instead. Lower
> the probability of breakage in the future and make the code easier
> to read.

Hi,

I have some spelling corrections (minor, but since you intend to re-roll
anyway, I'll post them), and one more thing which could be corrected
(below).

3/6: s/Never the less/Nevertheless/
4/6: s/masquerading/masking/     (masquerade means to "mask oneself")

>  	 if git apply --stat --summary broken 2>detected
>  	 then
>  		echo unhappy - should have detected an error
> @@ -79,7 +79,7 @@ test_expect_success 'apply detecting corrupt patch correctly' '
>  '
>  
>  test_expect_success 'apply detecting corrupt patch correctly' '
> -	 git diff --binary | sed -e 's/-CIT/xCIT/' >broken &&
> +	 git diff --binary | sed -e "s/-CIT/xCIT/" >broken &&
>  	 if git apply --stat --summary broken 2>detected
>  	 then
>  		echo unhappy - should have detected an error
I think this can be changed to:
   test_must_fail git apply --stat --summary broken 2>detected

-
Zbyszek