From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Wed, 13 Jun 2012 16:33:58 GMT
Subject: Re: git: Wrong parsing of ssh urls with IPv6 literals ignores port
Message-ID: <4FD8C0F6.8060609@lsrfire.ath.cx>
In-Reply-To: <20120612210003.GA16816@burratino>

Am 12.06.2012 23:00, schrieb Jonathan Nieder:
> Jonathan Nieder wrote:
>> René Scharfe wrote:
>
>>> How about this instead?
>>
>> Looks good to me.
>
> Oh, hold on a second.  Won't this get confused by
>
> 	ssh://[::1]/foo/bar/baz:80/qux
>
> ?

It shouldn't, because the host part is NUL-terminated before get_port() 
is called.  Let's see (with the patch):

	$ git clone ssh://[::1]/foo/bar/baz:80/qux
	Cloning into 'qux'...
	ssh: connect to host ::1 port 22: Connection refused
	fatal: The remote end hung up unexpectedly

René