From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Wed, 23 May 2012 16:20:03 GMT
Subject: Re: [PATCH 3/3] refs: use strings directly in find_containing_dir()
Message-ID: <4FBD0E33.4060309@lsrfire.ath.cx>
In-Reply-To: <7vhav73lnl.fsf@alter.siamese.dyndns.org>

Am 23.05.2012 00:18, schrieb Junio C Hamano:
> René Scharfe<rene.scharfe@lsrfire.ath.cx>  writes:
>
>> What has git grep to do with refs?  It checks if the path in the command
>> above is a ref, which makes it iterate over all of them..
>
> Do you mean:
>
> 	/* Is it a rev? */
>          get_sha1()
>          ->  ...
>            ->  get_sha1_basic()
>              ->  dwim_ref()
>
> callpath?

Yes, indeed.  Hmm, this is done even if the paths come after a 
double-dash.  Anyway, I don't consider the check to be a performance 
issue, just a quick way to test the allocation count that i stumbled 
upon while working on the recent grep patches.

René