From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Sat, 28 Apr 2012 11:09:18 GMT
Subject: Re: [PATCH] test: skip test with COLUMNS=1 under mksh
Message-ID: <4F9BCFDE.1090103@in.waw.pl>
In-Reply-To: <xmqqehr99mz3.fsf@junio.mtv.corp.google.com>

On 04/27/2012 06:08 PM, Junio C Hamano wrote:
> Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> writes:
> 
>> mksh does not allow $COLUMNS to be set below 12. Quoting mksh(1)
>> $COLUMNS is "always set, defaults to 80, unless the value as reported
>> by stty(1) is non-zero and sane enough". This applies also to setting
>> it directly for one command:
>>
>> $ COLUMNS=30 python -c 'import os; print os.environ["COLUMNS"]'
>> 30
>> $ COLUMNS=20 python -c 'import os; print os.environ["COLUMNS"]'
>> 20
>> $ COLUMNS=10 python -c 'import os; print os.environ["COLUMNS"]'
>> 98
> 
> I'd hate to say this, but that shell is broken.
Yes.

>> Let's test if we can set COLUMNS=1, and if not, skip the tests that
>> want to use that. A prereq is added, which is set if $COLUMNS can be
>> set.
> 
> And I think that is a sensible workaround, even though COLUMNS_CAN_BE_1
> might not be the best name for it.
> 
>> +( COLUMNS=1 && test $COLUMNS = 1 ) && test_set_prereq COLUMNS_CAN_BE_1
> 
> This is different from what you wrote in your log message, but I trust
> that it will fail under the problematic shell?
Yes.

> Will queue; thanks.
Cool.

Zbyszek