From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Wed, 11 Apr 2012 22:05:48 GMT
Subject: Re: [PATCH 1/5] t1507: add additional tests for @{upstream}
Message-ID: <4F86003C.3080308@in.waw.pl>
In-Reply-To: <vpqk41m40as.fsf@bauges.imag.fr>

On 04/11/2012 07:59 PM, Matthieu Moy wrote:
> Junio C Hamano<gitster@pobox.com>  writes:
>
>> We may want to update the error message for "@{u}" when the current one is
>> not tracked, instead of saying ''.  Perhaps
>>
>> 	error: No upstream branch found for the current branch.
>>
>> or something?
>>
>> Likewise for the detached HEAD case.
>
> This is indeed the point of the patch serie, and I like how it first
> shows how bad the error messages can be, and then illustrate the fix
> with patch hunks in the newly added testcases in further patches.
>
> But the commit message for this patch could probably be improved: we
> usually do not give a list of _what_ is done, since the code already
> says that, but we insist on _why_ it is done.
Yeah, I need to provide a better motivation/description in reroll.

Thanks for looking at this,
Zbyszek