From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Wed, 11 Apr 2012 21:51:27 GMT
Subject: Re: [PATCH 1/5] t1507: add additional tests for @{upstream}
Message-ID: <4F85FCDF.9040207@in.waw.pl>
In-Reply-To: <7vbomykv6x.fsf@alter.siamese.dyndns.org>

On 04/11/2012 07:57 PM, Junio C Hamano wrote:
> Junio C Hamano<gitster@pobox.com>  writes:
>
>> Zbigniew Jędrzejewski-Szmek<zbyszek@in.waw.pl>  writes:
>>
>>> +error_message () {
>>> +	(cd clone&&
>>> +	 test_must_fail git rev-parse --verify "$@")
>>> +}
>>> ...
>>> +test_expect_success 'branch@{u} error message when no upstream' '
>>> +	cat>expect<<-EOF&&
>>> +	error: No upstream branch found for ${sq}non-tracking${sq}
>>> +	fatal: Needed a single revision
>>> +	EOF
>>> +	(cd clone&&
>>> +	 test_must_fail git rev-parse --verify non-tracking@{u}) 2>actual&&
>>
>> Why not use "error_message" as other new tests?
There _was_ some reason, in some earlier version of the patch, but now it
is gone. Will use error_message.

> I think the remainder of the message should be ignored.  Will comment on
> individual steps.
>
> Thanks.
I'll try to improve the description in first patch to not confuse people :)

Thanks,
Zbyszek