From: Namhyung Kim <namhyung.kim@lge.com>
Date: Thu, 15 Mar 2012 06:29:04 GMT
Subject: Re: [PATCH 3/3] help: Add 'help.follow-alias' config item
Message-ID: <4F618C30.2030407@lge.com>
In-Reply-To: <7v7gymmm9a.fsf@alter.siamese.dyndns.org>

2012-03-15 3:06 PM, Junio C Hamano wrote:
> Namhyung Kim<namhyung.kim@lge.com>  writes:
>
>> The 'help.follow-alias' config option is used to determine the
>> default value of '--follow-alias' option. To do this, move some
>> codes to honor the priority of command line options.
>
> How badly would this change break what 7c3baa9 (help -a: do not
> unnecessarily look for a repository, 2009-09-04) tried to fix?
>

Oops, I was completely unaware of the problem, sorry :(.


>> diff --git a/Documentation/git-help.txt b/Documentation/git-help.txt
>> index debf293..9725e9f 100644
>> --- a/Documentation/git-help.txt
>> +++ b/Documentation/git-help.txt
>> @@ -80,6 +80,14 @@ line option:
>>   * "info" corresponds to '-i|--info',
>>   * "web" or "html" correspond to '-w|--web'.
>>
>> +help.follow-alias
>
> Please be consistent with existing ones.  I think we spell multi-word
> variable names without hyphens.
>

Will fix if you're OK with this series.

Thanks,
Namhyung