From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Thu, 08 Mar 2012 17:46:18 GMT
Subject: Re: [PATCH] fmt-merge-msg: show those involved in a merged series
Message-ID: <4F58F06A.1070108@lsrfire.ath.cx>
In-Reply-To: <7vzkbskr71.fsf@alter.siamese.dyndns.org>

Am 07.03.2012 22:59, schrieb Junio C Hamano:
> René Scharfe<rene.scharfe@lsrfire.ath.cx>  writes:
>
>> Am 05.03.2012 22:34, schrieb Junio C Hamano:
>>
>>> +#define util_as_int(elem) ((intptr_t)((elem)->util))
>>
>> Something that actually returns an int would fit the name better. ;)
>
> The particular type would not matter to the callers of the helper
> macro, would it?

Three of the five callers introduced in that commit cast the result to 
int and the remaining two don't care, so it actually does seem to matter 
for most of them, strictly speaking.  When I see a nit, I can't resist 
the urge to pick it, apparently.

René