From: Ramsay Jones Date: Mon, 13 Feb 2012 18:24:41 GMT Subject: [PATCH] builtin/tag.c: Fix a sparse warning Message-ID: <4F395569.8030106@ramsay1.demon.co.uk> In particular, sparse complains as follows: SP builtin/tag.c builtin/tag.c:411:5: warning: symbol 'parse_opt_points_at' was \ not declared. Should it be static? In order to suppress the warning, since the parse_opt_points_at() function does not need to be an external symbol, we simply add the static modifier to the function definition. Signed-off-by: Ramsay Jones --- builtin/tag.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin/tag.c b/builtin/tag.c index 8cfaaf8..fe7e5e5 100644 --- a/builtin/tag.c +++ b/builtin/tag.c @@ -408,7 +408,7 @@ static int strbuf_check_tag_ref(struct strbuf *sb, const char *name) return check_refname_format(sb->buf, 0); } -int parse_opt_points_at(const struct option *opt __attribute__ ((unused)), +static int parse_opt_points_at(const struct option *opt __attribute__((unused)), const char *arg, int unset) { unsigned char sha1[20]; -- 1.7.9