From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Tue, 13 Dec 2011 03:23:30 GMT
Subject: Re: [PATCH 4/4] connect.c: drop path_match function
Message-ID: <4EE6C532.9060306@alum.mit.edu>
In-Reply-To: <20111213004959.GD3699@sigill.intra.peff.net>

On 12/13/2011 01:49 AM, Jeff King wrote:
> I just did the exact-string match inline in the previous patch. I could
> also have modified path_match to do it. But really, I can't think of a
> worse name for a global function in a system which is all about
> managing content in paths. Unless, you know, it actually matched paths.
> Which it doesn't.

The tacit assumption that a reference is always a file is all over the
code and is often confusing.  My

    [PATCH v2 02/51] refs: rename "refname" variables

is a step towards making the distinction more explicit, at least in the
refs code.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/