From: René Scharfe Date: Mon, 12 Dec 2011 22:37:02 GMT Subject: Re: [PATCH v3 0/3] grep attributes and multithreading Message-ID: <4EE6820E.7010605@lsrfire.ath.cx> In-Reply-To: Am 12.12.2011 22:16, schrieb Thomas Rast: > I think we should finish up these three patches for the next release. > I already posted a bunch of POC patches, but doing the timing manually > has been getting on my nerves lately. So I would first like to > formalize some of the performance testing, perhaps along lines already > drawn up by Michael Hagger, perhaps not. Then we can revisit the > issue of grep performance. But I would prefer not to block the -W fix > and two easy and confirmed speedups on that. Yes, that's a good idea. The three patches are uncontroversial incremental improvements. > I dropped this part entirely: > >> How about adding a parameter to control the number of threads >> (--threads?) instead that defaults to eight (or five) for the worktree >> and one for the rest? That would also make benchmarking easier. > > It does make testing a lot easier, but the interface is IMHO not fit > for users and I have a feeling that the "right" for-debugging > interface will end up falling out of the performance testing work > (probably an environment variable). The end-user option should be a > config setting, if any. Agreed; users shouldn't need to specify such a parameter -- our heuristic should be good enough. René