From: Michael Haggerty Date: Wed, 12 Oct 2011 02:56:42 GMT Subject: Re: Re* [PATCH v3 19/22] resolve_ref(): emit warnings for improperly-formatted references Message-ID: <4E9501EA.8060409@alum.mit.edu> In-Reply-To: <7vehyjcckp.fsf@alter.siamese.dyndns.org> On 10/12/2011 01:50 AM, Junio C Hamano wrote: > It starts sounding like that the ill-thought-out warning should be ripped > out regardless of what other things we do. ISTM that the warning is proving its worth already by illuminating some questionable practices (treating any file in $GIT_DIR as a potential reference) :-) However, it might be that fixing 100% of the questionable practices is too much work. In that case, I suggest that the warning not be ripped out altogether, but rather that the warning only be emitted for invalid references whose names start with "refs/". Michael -- Michael Haggerty mhagger@alum.mit.edu http://softwareswirl.blogspot.com/