From: Michael Haggerty Date: Sun, 02 Oct 2011 04:58:53 GMT Subject: Re: [PATCH] Don't sort ref_list too early Message-ID: <4E87EF8D.8020801@alum.mit.edu> In-Reply-To: <20110927000010.79913.71464.julian@quantumfyre.co.uk> On 09/27/2011 02:00 AM, Julian Phillips wrote: > get_ref_dir is called recursively for subdirectories, which means that > we were calling sort_ref_list for each directory of refs instead of > once for all the refs. This is a massive wast of processing, so now > just call sort_ref_list on the result of the top-level get_ref_dir, so > that the sort is only done once. +1 I think this patch should also be considered for maint, since it is noninvasive and fixes a bad performance regression. Michael -- Michael Haggerty mhagger@alum.mit.edu http://softwareswirl.blogspot.com/