From: Johannes Sixt <j6t@kdbg.org>
Date: Sun, 07 Aug 2011 20:02:03 GMT
Subject: Re: [PATCH v2 4/4] upload-archive: use start_command instead of fork
Message-ID: <4E3EEF3B.80908@kdbg.org>
In-Reply-To: <4E3D0C1D.9000807@lsrfire.ath.cx>

Am 06.08.2011 11:40, schrieb René Scharfe:
> So here's an ugly patch to implement an internal passthrough filter to
> avoid newline conversions.  It makes the tar filter command (gzip etc.)
> write to a pipe instead of directly to a file.

*If* we are working around the CRLF conversion issue in git itself,
wouldn't it be much simpler to just:

diff --git a/archive-tar.c b/archive-tar.c
index 20af005..da3d98a 100644
--- a/archive-tar.c
+++ b/archive-tar.c
@@ -364,9 +364,9 @@ void init_tar_archiver(void)
 	int i;
 	register_archiver(&tar_archiver);

-	tar_filter_config("tar.tgz.command", "gzip -cn", NULL);
+	tar_filter_config("tar.tgz.command", "gzip -cn | cat", NULL);
 	tar_filter_config("tar.tgz.remote", "true", NULL);
-	tar_filter_config("tar.tar.gz.command", "gzip -cn", NULL);
+	tar_filter_config("tar.tar.gz.command", "gzip -cn | cat", NULL);
 	tar_filter_config("tar.tar.gz.remote", "true", NULL);
 	git_config(git_tar_config, NULL);
 	for (i = 0; i < nr_tar_filters; i++) {

(provided that 'cat' magically does not suffer from the same problem,
and I do think that it does not.)

Anyway, I think it would be better to address the problem on the msysgit
side. Perhaps by providing a gzip of a different vintage (e.g. a
self-compiled one) that does not suffer from the CRLF conversion issue.

-- Hannes