From: René Scharfe Date: Fri, 05 Aug 2011 15:31:37 GMT Subject: Re: [RFC/PATCH 0/5] macro-based key/value maps Message-ID: <4E3C0CD9.4020902@lsrfire.ath.cx> In-Reply-To: <20110805110302.GA23619@sigill.intra.peff.net> Am 05.08.2011 13:03, schrieb Jeff King: > Commits 1, 4, and 5 introduce infrastructure in the form of static > functions and macros that contain functions that call the statics. But > they don't actually instantiate the macro functions themselves, so > they won't compile with -Werror (due to the "unused static" warning) > until there is some calling code. > > That hurts bisectability a little if you compile with -Werror (you > need to add -Wno-error=unused-function). I don't know how much we > care. I don't know either, but you could avoid the issue by adding a test-maps command in the first patch and exercising the new functionality a bit. René