From: Jon Forrest Date: Mon, 01 Aug 2011 04:57:02 GMT Subject: Re: [PATCH] For Real - Fixed pluralization in diff reports Message-ID: <4E36321E.2040409@gmail.com> In-Reply-To: On 7/31/2011 9:50 PM, Nguyen Thai Ngoc Duy wrote: > Are you sure this does not break any tests? t3508.2 for example > hardcodes "1 insertions" and does textual compare. I have not run the > tests but I suspect it will fail. I ran the tests. The only result in red that I saw that didn't appear to be caused "by breakage" was not ok - 3 mktemp to unwritable directory prints filename Since I didn't do anything relating to mktemp I thought this was probably bogus. I'm new to this so I don't know how to find the t3508.2. If you can give me a hint I'd be glad to look at this in more detail. Jon