From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Tue, 19 Jul 2011 17:28:59 GMT
Subject: Re: [PATCH] Fix config_file file leak.
Message-ID: <4E25BEDB.6040002@ramsay1.demon.co.uk>
In-Reply-To: <20110714181948.GA23288@localhost>

Chris Wilson wrote:
> Hi,
> 
> We are using Sentry (a C/C++ static analysis tool) to analyze
> git on a nightly basis. Sentry found that a file leak
> was recently introduced in the commit 924aaf3.

Hmmm ..., commit 924aaf3 did *not* introduce a file handle leak.
It would seem that the change in scope of the file handle made it
easier for Sentry to see the *existing* (potential) file handle leak.

no?

Other than that, ...

ATB,
Ramsay Jones