From: Marc Branchaud <marcnarc@xiplink.com>
Date: Wed, 29 Jun 2011 17:34:53 GMT
Subject: Re: [RFC 2/2] Don't push a repository with unpushed submodules
Message-ID: <4E0B623D.1060507@xiplink.com>
In-Reply-To: <20110628230248.GA4436@paksenarrion.iveqy.com>

On 11-06-28 07:02 PM, Fredrik Gustafsson wrote:
> 
>  [ ... ]
> 
> Serverside, we cannot guarantee that all submodules are reachable, they
> might be on different servers, maybe not even connected to eachothers. Even
> if they are connected this would requiring network traffic. Making this check 
> an even bigger performance killer. This check is not supposed to guarantee a 
> sane server-repo (that would be much harder) and therefore this check is 
> "overkill" to have on the server-side. Client side we always have all
> information needed for this.
> 
> Note the problem:
> "Prevent the developer of pushing a superrepo that has submodule
> (commits) only locally avaliable"
> 
> That's the problem we're trying to solve, NOT:
> 
> "Prevent the developer of pushing a superrepo that has submodule
> (commits) not avaliable for an other developer"
> 
> The second problem is just too complex and too slow to solve in a generic
> way.

Fair enough.

So my only remaining concern is that using "push -f" to override the check is
too much.  I'd rather see a different option control this.  Maybe
--ignore-submodules?  (I think it'd be fine if -f implied --ignore-submodules.)

		M.