From: Markus Duft <mduft@gentoo.org>
Date: Wed, 15 Jun 2011 09:31:57 GMT
Subject: Re: [PATCH 2/2] Include unistd.h.
Message-ID: <4DF87C0D.3050108@gentoo.org>
In-Reply-To: <4DE33E55.6090505@gentoo.org>

On 05/30/11 08:51, Markus Duft wrote:
> On 05/26/11 18:39, Jonathan Nieder wrote:
>> Junio C Hamano wrote:
>>
>>> --- a/compat/fnmatch/fnmatch.c
>>> +++ b/compat/fnmatch/fnmatch.c
>>> @@ -127,6 +127,10 @@ extern char *getenv ();
>>>  extern int errno;
>>>  # endif
>>> +
>>> +# ifndef NULL
>>> +#  define NULL 0
>>> +# endif
>>
>> Makes a lot of sense.  This fits well with the style of the rest of
>> the file and other projects using glibc fnmatch could reuse the fix
>> even if targeting ancient platforms.
> 
> I tested, and it works well on interix. Will you commit, or should i prepare a patch?

ping... is this one ok now?

about the other patch (1/2), i'm sorry that i messed up the thread a little... my last response was at [1]. could you take a look at it and tell me whether the patch is ok as is?

[1] http://news.gmane.org/find-root.php?message_id=%3c4DDF4440.4040405%40gentoo.org%3e

thanks,
markus

> 
> Thanks
> Markus