From: Markus Duft Date: Mon, 30 May 2011 06:51:01 GMT Subject: Re: [PATCH 2/2] Include unistd.h. Message-ID: <4DE33E55.6090505@gentoo.org> In-Reply-To: <20110526163921.GD24931@elie> On 05/26/11 18:39, Jonathan Nieder wrote: > Junio C Hamano wrote: > >> --- a/compat/fnmatch/fnmatch.c >> +++ b/compat/fnmatch/fnmatch.c >> @@ -127,6 +127,10 @@ extern char *getenv (); >> extern int errno; >> # endif >> + >> +# ifndef NULL >> +# define NULL 0 >> +# endif > > Makes a lot of sense. This fits well with the style of the rest of > the file and other projects using glibc fnmatch could reuse the fix > even if targeting ancient platforms. I tested, and it works well on interix. Will you commit, or should i prepare a patch? Thanks Markus