From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Sat, 21 May 2011 22:08:46 GMT
Subject: Re: [PATCH 4/4] streaming filter: ident filter and filter cascading
Message-ID: <4DD837EE.3010608@lsrfire.ath.cx>
In-Reply-To: <4DD82931.6000101@lsrfire.ath.cx>

Am 21.05.2011 23:05, schrieb René Scharfe:
>> +		if (ident->state < sizeof(head) &&
> 
> 		// minus one because otherwise we'd compare the
> 		// terminating NUL as well even though we're not
> 		// actually looking for a NUL
> 		if (ident->state < sizeof(head) - 1 &&

Possibly, but that doesn't matter, as the right number of characters is
remembered and the second test below is not passed if we sailed past the
NUL.  Sorry for the noise.

> 
>> +		    head[ident->state] == ch) {
>> +			ident->state++;
>> +			continue;
>> +		}
>> +
>> +		if (ident->state)
>> +			strbuf_add(&ident->left, head, ident->state);
>> +		if (ident->state == sizeof(head) - 1) {