From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Fri, 01 Apr 2011 06:52:56 GMT
Subject: Re: [PATCH 2/3] sha1_name: Suggest commit:./file for path in subdir
Message-ID: <4D957648.8070008@drmicha.warpmail.net>
In-Reply-To: <7vsju3jdm2.fsf@alter.siamese.dyndns.org>

Junio C Hamano venit, vidit, dixit 31.03.2011 21:26:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
>> Currently, the "Did you mean..." message suggests "commit:fullpath"
>> only. Extend this to show the more convenient "commit:./file" form also.
> 
> If we were to do this, I suspect that with non-empty prefix we should only
> show "./$file" form for brevity without aka.  This is a end-user facing
> message and not meant to help scripts, no?

ENOPARSE

Do you mean:

- replace the old "commit:fullpath" with "commit:./file" or

- show the new form only without "aka" (but with the old form) or

- show literal "commit:./$file"?

I guess you meant the first one. But I left in both forms on purpose:
Saying only "commit:./file" does not explain what it means, the "./"
part is easy to miss, and the user may not even be aware to be in a
subdir. Listing both does not take much space and explains everything.

Michael