From: Johannes Sixt Date: Tue, 11 Jan 2011 07:44:30 GMT Subject: [PATCH 2/2] t/README: hint about using $(pwd) rather than $PWD in tests Message-ID: <4D2C0A5E.7090708@viscovery.net> In-Reply-To: <4D2C09D7.3070700@viscovery.net> From: Johannes Sixt This adds just a "do it this way" instruction without a lot of explanation, because the details are too complex to be explained at this point. Signed-off-by: Johannes Sixt --- t/README | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/t/README b/t/README index 90718b4..f98ebb3 100644 --- a/t/README +++ b/t/README @@ -283,6 +283,12 @@ Do: Tests that are likely to smoke out future regressions are better than tests that just inflate the coverage metrics. + - When a test checks for an absolute path that a git command generated, + construct the expected value using $(pwd) rather than $PWD, + $TEST_DIRECTORY, or $TRASH_DIRECTORY. It makes a difference on + Windows, where the shell (MSYS bash) mangles absolute path names. + For details, see the commit message of 4114156ae9. + Don't: - exit() within a