From: Brian Gernhardt <benji@silverinsanity.com>
Date: Wed, 30 Jul 2008 21:16:55 GMT
Subject: Re: [PATCH v3] Advertise the ability to abort a commit
Message-ID: <4D1D0F77-C2BE-4513-B664-80505957CB06@silverinsanity.com>
In-Reply-To: <32541b130807301409t2f1f3a80n44c62447c628f03a@mail.gmail.com>


On Jul 30, 2008, at 5:09 PM, Avery Pennarun wrote:

> On 7/30/08, Brian Gernhardt <benji@silverinsanity.com> wrote:
>> 'git commit' should return with an error any time it does not commit.
>> Otherwise scripts could get confused, thinking everything went fine  
>> when
>> nothing actually got done.  Here, the user decided something was in  
>> error
>> and canceled out, the same way using using ^C causes a non-zero  
>> return
>> status.
>
> The patch uses a non-zero exit code, which is an error status.  But as
> that's the case, I'm not sure why it's described in the changelog as
> treating it "not as an error."

Sorry, was reading through the list too quickly.  Of course an exit  
code of 1 is an error.  I'll go back to hiding under my rock now.

~~ Brian