From: Johannes Sixt <j.sixt@viscovery.net>
Date: Mon, 20 Dec 2010 08:04:11 GMT
Subject: Re: [PATCH] convert filter: supply path to external driver
Message-ID: <4D0F0DFB.20502@viscovery.net>
In-Reply-To: <20101219212925.GA7393@arf.padd.com>

Am 12/19/2010 22:29, schrieb Pete Wyckoff:
> Filtering to support keyword expansion may need the name of
> the file being filtered.  In particular, to support p4 keywords
> like
> 
>     $File: //depot/product/dir/script.sh $
> 
> the smudge filter needs to know the name of the file it is
> smudging.
> 
> Add a "%s" conversion specifier to the gitattribute for filter.
> It will be expanded with the path name to the file when invoking
> the external filter command.

What happens if there are any shell special characters in the path name
(or spaces, for that matter). Does this shell-escape the substituted path
name anywhere in the call chain?

-- Hannes