From: Stephen Boyd Date: Fri, 03 Dec 2010 07:35:35 GMT Subject: Re: [PATCH 1/6] parse-options: sanity check PARSE_OPT_NOARG flag Message-ID: <4CF89DC7.2050806@gmail.com> In-Reply-To: <7v7hftt7vy.fsf@alter.siamese.dyndns.org> On 12/01/10 15:01, Junio C Hamano wrote: > Stephen Boyd writes: > >> Looks like parse_options_check() is being called for each >> parse_options_step(). Here's a patch to fix that. Junio, this can >> probably be applied to maint. > > Looks correct, but why is it a maint material? > Possible performance regression? Which is why its qualified with probably.