From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Tue, 23 Nov 2010 19:31:03 GMT
Subject: Re: [PATCH v2 5/6] msvc: opendir: handle paths ending with a slash
Message-ID: <4CEC1677.6000207@lsrfire.ath.cx>
In-Reply-To: <1290537509-360-6-git-send-email-kusmabite@gmail.com>

Am 23.11.2010 19:38, schrieb Erik Faye-Lund:
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>  compat/msvc.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/compat/msvc.c b/compat/msvc.c
> index 199eb22..fdbfb70 100644
> --- a/compat/msvc.c
> +++ b/compat/msvc.c
> @@ -23,6 +23,8 @@ DIR *opendir(const char *name)
>  
>  	/* check that the pattern won't be too long for FindFirstFileA */
>  	len = strlen(name);
> +	if (is_dir_sep(name[len - 1]))

Perhaps extend this thus, and handle multiple slashes?

	while (len > 0 && is_dir_sep(name[len - 1]))

> +		len--;
>  	if (len + 2 >= MAX_PATH) {
>  		errno = ENAMETOOLONG;
>  		return NULL;