From: Eric Sunshine <ericsunshine@gmail.com>
Date: Thu, 04 Nov 2010 22:53:28 GMT
Subject: Re: [PATCH] attr: support quoting pathname patterns in C style
Message-ID: <4CD33968.4060704@gmail.com>
In-Reply-To: <1288878944-14066-1-git-send-email-pclouds@gmail.com>

On 11/4/2010 9:55 AM, Nguyễn Thái Ngọc Duy wrote:
> Full pattern must be quoted. So 'pat"t"ern attr' will give exactly
> 'pat"t"ern', not 'pattern'. Also clarify that leading whitespaces are
> not part of the pattern and document comment syntax.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy<pclouds@gmail.com>
> diff --git a/attr.c b/attr.c
> index 6aff695..f3063d8 100644
> --- a/attr.c
> +++ b/attr.c
>   	name = cp;
> -	namelen = strcspn(name, blank);
> +	if (*cp == '"') {
> +		if (unquote_c_style(&pattern, name,&ep))
> +			die("Broken attribute line: %s", line);

The error message is perhaps a bit too generic, indicating only that 
_something_ on the line caused a problem. Mentioning that bad quoting of 
'name' was at fault would help focus the user's attention where it is 
needed.

-- ES