From: Jens Lehmann <jens.lehmann@web.de>
Date: Mon, 06 Sep 2010 20:12:38 GMT
Subject: Re: [PATCH] Several tests: cd inside subshell instead of around
Message-ID: <4C854B36.6010606@web.de>
In-Reply-To: <20100906190655.GG25426@burratino>

Am 06.09.2010 21:06, schrieb Jonathan Nieder:
> Do you think it would be a bad idea if I send a follow-on patch that
> changes code like this:
> 
> 	(cd dir &&
>  	git update-index --add two &&
>  	case "`git ls-files`" in
>  	two) echo pass two ;;
>  	*) echo bad two; exit 1 ;;
> 	esac
> 	) &&
> 
> to this:
> 
> 	(
> 		cd dir &&
> 		git update-index --add two &&
> 		case "`git ls-files`" in
> 		two) echo pass two ;;
> 		*) echo bad two; exit 1 ;;
> 		esac
> 	)
> 
> It would have the benefit of touching all code in the subshell, so we
> could see the effect on "exit" commands and whatnot.

I think that makes a lot of sense. I think you would not only end up
changing the indentation of many subshells (not only those that I
added), you will also have to deal with tests using spaces instead of
tabs for indentation. But these issues have to be addressed anyway ...