From: Johannes Sixt <j.sixt@viscovery.net>
Date: Wed, 18 Aug 2010 10:45:54 GMT
Subject: Re: [PATCH] submodule sync: Update "submodule.<name>.url"
Message-ID: <4C6BB9E2.4060700@viscovery.net>
In-Reply-To: <1282125673-22956-1-git-send-email-davvid@gmail.com>

Am 8/18/2010 12:01, schrieb David Aguilar:
> @@ -840,9 +840,10 @@ cmd_sync()
>  		then
>  		(
>  			clear_local_git_env
> +			say "Synchronizing submodule url for '$name'"
> +			git config submodule."$name".url "$url"

This git config applies to the super module, right? As such, shouldn't it
happen before you clear_local_git_env?

>  			cd "$path"
>  			remote=$(get_default_remote)
> -			say "Synchronizing submodule url for '$name'"
>  			git config remote."$remote".url "$url"
>  		)

-- Hannes