From: Johannes Sixt <j6t@kdbg.org>
Date: Fri, 13 Aug 2010 21:33:58 GMT
Subject: Re: jn/svn-fe
Message-ID: <4C65BA46.9010604@kdbg.org>
In-Reply-To: <20100813000848.GA8076@burratino>

Am 13.08.2010 02:08, schrieb Jonathan Nieder:
> (pruned Ccs)
>
> Johannes Sixt wrote:
>> Am 8/12/2010 1:35, schrieb Junio C Hamano:
>
>>> * jn/svn-fe (2010-08-09) 10 commits
> [...]
>> This fails to build under MinGW because we don't have strtok_r() and a
>> whole lot of other things that I didn't even look at. Can we have an
>> opt-in or opt-out for this?
>
> How about something like this instead?
>
> -- 8<  --
> Subject: vcs-svn: Port to Windows
>
> MSys #define-s dirent away.  Avoid trouble by avoiding that
> identifier.
>
> Windows does not have strtok_r (and while does have an identical
> strtok_s, but it is not obvious how to use it).  Grab an
> implementation from glibc.
>
> The svn-fe test fails in the “svn export” step because of the
> lack of symlink support.  With a less ambitious dump, it passes.
>
> Cc: Johannes Sixt<j6t@kdbg.org>
> Cc: Ramkumar Ramachandra<artagnon@gmail.com>
> Signed-off-by: Jonathan Nieder<jrnieder@gmail.com>

Thanks, it compiles with this patch and passes the test suite.

Acked-by: Johannes Sixt<j6t@kdbg.org>

The license, LGPL 2.1 or later is OK, I assume?

-- Hannes