From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Fri, 06 Aug 2010 21:41:39 GMT
Subject: Re: [PATCH] prune: allow --dry-run for -n and --verbose for -v
Message-ID: <4C5C8193.1040608@lsrfire.ath.cx>
In-Reply-To: <20100806210429.GA6495@burratino>

Am 06.08.2010 23:04, schrieb Jonathan Nieder:
> René Scharfe wrote:
>
>> +++ b/builtin/prune.c
>> @@ -125,10 +125,9 @@ int cmd_prune(int argc, const char **argv, const char *prefix)
>>   {
>>   	struct rev_info revs;
>>   	const struct option options[] = {
>> -		OPT_BOOLEAN('n', NULL, &show_only,
>> +		OPT_BOOLEAN('n', "dry-run", &show_only,
>
> For the curious: avoiding OPT__DRY_RUN allows us to give a better
> description:
>
>>   			"do not remove, show only"),
>
> which makes sense to me.  Thanks.

Indeed.

Adding a helptext parameter to OPT__DRY_RUN à la OPT__COLOR would make 
it usable here as well as in commit.c and fetch.c.  Similar changes 
could help OPT__VERBOSE and OPT__QUIET.  Their standard helptexts don't 
add a lot of information..

René