From: Jens Lehmann <jens.lehmann@web.de>
Date: Thu, 05 Aug 2010 23:51:28 GMT
Subject: Re: [PATCH v2 0/2] Submodules: Add the new config option "ignore"
Message-ID: <4C5B4E80.1070102@web.de>
In-Reply-To: <7vvd7obpy5.fsf@alter.siamese.dyndns.org>

Am 06.08.2010 01:27, schrieb Junio C Hamano:
> Jens Lehmann <Jens.Lehmann@web.de> writes:
> 
>> Am 28.07.2010 23:35, schrieb Junio C Hamano:
>>> The value of "submodule.<name>.path" does not have to be "<name>".  There
>>> seems to be a bit of confusion here.
>>
>> Thanks for clearing up my confusion, this is v2 of this patch using the
>> path configured for the submodule instead of its name.
> 
> Hmph, I thought that it would make more sense to use <name> so that once
> the user configures ignore in .git/config, it will persist across moving
> of the submodule in the superproject tree.  I wonder what others would
> think.

I think that is just what this patch does, it uses the
"config_name_for_path" string_list to get the submodules <name> for the
path to then look up what is configured for the "ignore" option under
that <name>. So the "ignore" option should survive renames, no? Or did
I manage to confuse myself again?