From: Stephen Boyd <bebarino@gmail.com>
Date: Wed, 28 Jul 2010 07:33:55 GMT
Subject: Re: [PATCH] hash: Remove useless init_hash()
Message-ID: <4C4FDD63.9050303@gmail.com>
In-Reply-To: <AANLkTikHLZlBQW8DSZrxeA-RDOh2Iy6hc0p821tDQoN8@mail.gmail.com>

  On 07/27/2010 12:58 PM, Ævar Arnfjörð Bjarmason wrote:
>
>> That being said, I agree with the comments that removing init_hash
>> actually makes the code _less_ readable. You could just replace these
>> three lines with a memset, but why? It's just code churn.
> Yeah, and for the record it also missed this part in hash.c:
>
>      void free_hash(struct hash_table *table)
>      {
>      	free(table->array);
>      	table->array = NULL;
>      	table->size = 0;
>      	table->nr = 0;
>      }
>
> Have fun everyone :)

Ok, seems like nobody thinks this is a good idea so I'm fine with dropping it. The minimal savings (if at all) doesn't seem worth the code churn. One less patch in the queue ;-)