From: Stephen Boyd <bebarino@gmail.com>
Date: Sat, 24 Jul 2010 08:32:00 GMT
Subject: Re: [WIP/RFC 09/13] git notes merge: Initial implementation handling trivial merges only
Message-ID: <4C4AA500.7010205@gmail.com>
In-Reply-To: <1279880104-29796-10-git-send-email-johan@herland.net>

  On 07/23/2010 03:15 AM, Johan Herland wrote:
> +	if (1<  argc) {
> +		error("too many parameters");
> +		usage_with_options(git_notes_merge_usage, options);
> +	} else if (1>  argc) {
> +		error("too few parameters");
> +		usage_with_options(git_notes_merge_usage, options);
> +	}
> +
>

Looks like it only takes one <notes_ref>. In that case wouldn't it be better to say

     if (argc != 1) {
         error("Must specify a note ref to merge");
         usage_with_options(git_notes_merge_usage, options)
     }