From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Fri, 09 Jul 2010 09:33:15 GMT
Subject: Re: [PATCH] tests: Use skip_all=* to skip tests
Message-ID: <4C36ECDB.9090707@drmicha.warpmail.net>
In-Reply-To: <1278551766-27569-1-git-send-email-avarab@gmail.com>

After trying out tests with prove (I like it!) I was just about to make
a patch before I saw this...

So, this does what it should, at least with my set of prerequisites.

Ævar Arnfjörð Bjarmason venit, vidit, dixit 08.07.2010 03:16:
> Change tests to skip with skip_all=* + test_done instead of using say
> + test_done.

I didn't understand this at all at first, only after I was about to
write that patch myself. Maybe 'with skip_all="reason"' or
'skip_all=<reason>' etc.?

> 
> This is a follow-up to "tests: Skip tests in a way that makes sense
> under TAP" (fadb5156e4). I missed these cases when prepearing that

"preparing", although that last sentence sounds more like "after ---
material".

> patch, hopefully this is all of them.
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

No comments to the patch itself, it works :)

Michael