From: Johannes Sixt Date: Fri, 02 Jul 2010 05:49:43 GMT Subject: Re: [RFC PATCH] rerere: fix overeager gc Message-ID: <4C2D7DF7.8030408@viscovery.net> In-Reply-To: <7v1vbn417d.fsf@alter.siamese.dyndns.org> Am 7/1/2010 18:27, schrieb Junio C Hamano: > Johannes Sixt writes: > >> Would it be possible to update the timestamp of preimage every time it is >> used (e.g., in rerere.c:merge()), and check for that? > > It would be _possible_, but we are _not_ modifying the file at that point, > so somehow that solution feels very wrong, no? rr-cache is basically a static database. The fact that we have a file named 'thisimage' is just an abuse - to put a temporary file somewhere. Therefore, depending on lockfile infrastructure to change timestamps for us while manipulating 'thisimage' should feel no less wrong, don't you think so? -- Hannes