From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Fri, 25 Jun 2010 20:24:02 GMT
Subject: Re: [PATCH 4/4] Makefile: Don't pass $(ALL_CFLAGS) to the linker
Message-ID: <4C251062.8040507@ramsay1.demon.co.uk>
In-Reply-To: <AANLkTinmGOSwNzLBngXHOU-pxNTbHFJQyCLIHQWFW6Eo@mail.gmail.com>

Peter Harris wrote:
> On Wed, Jun 23, 2010 at 3:48 PM, Ramsay Jones wrote:
>> The msvc debug build (make MSVC=1 DEBUG=1) issues a warning
>> on every invocation of the linker:
>>
>>    LINK : warning LNK4044: unrecognized option '/Zi'; ignored
>>
>> In order to suppress the warning, we refrain from passing the
>> $(ALL_CFLAGS) macro to the linker.
> 
> Alternatively, we could leave the makefile alone and fix it up in
> compat/vcbuild/scripts/clink.pl

Hmm, OK ... but it would be much easier if we didn't pass inappropriate
options in the first place. :-P

Also, are you correctly filtering *all* possible inappropriate options?
For example, the very next patch on my branch (not sent to list) adds
a -W3 option ... ;-)

ATB,
Ramsay Jones