From: William Pursell Date: Tue, 08 Jun 2010 22:27:28 GMT Subject: Re: permissions Message-ID: <4C0EC3D0.6060509@wpursell.net> In-Reply-To: <7vtypds09x.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > Alex Riesen writes: > >> On Tue, Jun 8, 2010 at 12:25, William Pursell wrote: >>> Here's a patch. This doesn't address the issue of a damaged >>> repository, but just catches access errors and permissions. >> The change looks fishy. >> >> The patch moves the function is_git_directory at the level of user >> interface where it wasn't before: it now complains and die. >> Not all callers of the function call it only to die if it fails. > > Thanks for shooting it down before I had to look at it ;-) The point of the patch is that it now complains and dies. Perhaps I'm being obtuse, but can you describe a situation in which this causes git to terminate inappropriately? -- William Pursell