From: Johannes Sixt <j.sixt@viscovery.net>
Date: Mon, 12 Apr 2010 06:30:33 GMT
Subject: Re: [PATCH 1/2] index-pack: smarter memory usage when resolving deltas
Message-ID: <4BC2BE09.7060809@viscovery.net>
In-Reply-To: <1271041047-32563-1-git-send-email-nico@fluxnic.net>

Am 4/12/2010 4:57, schrieb Nicolas Pitre:
> --- a/builtin/index-pack.c
> +++ b/builtin/index-pack.c
> @@ -359,34 +359,33 @@ static void *get_data_from_pack(struct object_entry *obj)
>  {
>  	off_t from = obj[0].idx.offset + obj[0].hdr_size;
>  	unsigned long len = obj[1].idx.offset - from;
> -	unsigned long rdy = 0;
> -	unsigned char *src, *data;
> +	unsigned char *data, inbuf[4096];

With this tiny buffer we make way more pread() calls than we used to,
right? This hurts emulated pread(), where we do at least 4 syscalls per
pread(). Shouldn't the buffer be much larger, like min(len,16*4096)?

-- Hannes