From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Mon, 15 Mar 2010 23:16:59 GMT
Subject: Re: [PATCH RFC] cherry: support --abbrev option
Message-ID: <4B9EBFEB.5070108@lsrfire.ath.cx>
In-Reply-To: <40aa078e1003151530y19f10bf1l852a0e5230b11cb6@mail.gmail.com>

Am 15.03.2010 23:30, schrieb Erik Faye-Lund:
> On Mon, Mar 15, 2010 at 6:08 PM, René Scharfe
>> If I use --no-abbrev, do I get 0 or 40 hash chars?  I didn't actually
>> test it, but I suspect an "if (!abbrev) abbrev = 40;" is needed somewhere.
> 
> "abbrev" is initialized to 40 when declared, so you get the same
> behavior as before by default.

Yes, but --no-abbrev sets it to zero.  Which is OK, though, as I found
out after actually testing your patch this time.  A closer look at
find_unique_abbrev() in sha1_name.c reveals that the function returns
the full hash if len is either 40 or 0.

So you could initialize abbrev to zero and avoid the magic constant 40
there altogether.  (Is this still nitpicking or already bikeshedding? ;)

René