From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Mon, 08 Mar 2010 14:08:09 GMT
Subject: Re: [PATCH 00/12] Support columinized output in tag/branch/ls-files/grep
Message-ID: <4B9504C9.5000703@lsrfire.ath.cx>
In-Reply-To: <1267963785-473-1-git-send-email-pclouds@gmail.com>

Am 07.03.2010 13:09, schrieb Nguyễn Thái Ngọc Duy:
> This adds support to show columnized output in the mentioned commands.

That's a good idea.

I'm not so sure about the interface, though.  Does the task really
warrant adding a new git command?

If a --column parameter is added, I think it should expose the full
range of options, i.e. fill columns first (ls -C style), fill rows first
(ls -x style) as well as off (ls -1 style) and auto.

Shouldn't the columnizer use utf8_width() instead of strlen(), like
strbuf_add_wrapped_text() in utf8.c?

René