From: Stephen Boyd Date: Sun, 07 Mar 2010 21:54:52 GMT Subject: Re: [PATCH 2/4] format-patch: use a string_list for headers Message-ID: <4B9420AC.1030104@gmail.com> In-Reply-To: <40aa078e1003071344h5ef4358aif7888afdad1b4fc6@mail.gmail.com> On 03/07/2010 01:44 PM, Erik Faye-Lund wrote: > On Sun, Mar 7, 2010 at 10:33 PM, Stephen Boyd wrote: > >> +static struct string_list extra_hdr = { .strdup_strings = 1 }; >> +static struct string_list extra_to = { .strdup_strings = 1 }; >> +static struct string_list extra_cc = { .strdup_strings = 1 }; >> >> > Do we really use this C99 feature (designated initializers)? I think > it will break MSVC builds, at least... Perhaps some other non-gcc > platforms as well? > Figured as much. Not a problem to fix. Thanks.