From: Johannes Sixt <j6t@kdbg.org>
Date: Fri, 26 Feb 2010 17:41:02 GMT
Subject: Re: [PATCH v2 1/3] git-svn: Support retrieving passwords with GIT_ASKPASS
Message-ID: <4B8807AE.2090502@kdbg.org>
In-Reply-To: <1267142845-3040-1-git-send-email-lznuaa@gmail.com>

Frank Li schrieb:
> +if (! exists $ENV{GIT_ASKPASS}) {
> +	if (exists $ENV{SSH_ASKPASS}) {
> +		$ENV{GIT_ASKPASS} = $ENV{SSH_ASKPASS};
> +		if ($^O eq 'msys') {
> +                        $ENV{GIT_ASKPASS} =~ s/\\/\\\\/g;
> +                        $ENV{GIT_ASKPASS} =~ s/(.*)/"$1"/;

Don't quote GIT_ASKPASS here.

> +	if (exists $ENV{GIT_ASKPASS}) {
> +		open(PH, "$ENV{GIT_ASKPASS} \"$prompt\" |");

		open(PH, "-|", $ENV{GIT_ASKPASS}, $prompt);

and you don't have to do any quoting at all, no?

-- Hannes