From: Johannes Sixt <j.sixt@viscovery.net>
Date: Wed, 24 Feb 2010 08:06:01 GMT
Subject: Re: [PATCHv4 6/6] is_submodule_modified(): clear environment properly
Message-ID: <4B84DDE9.8000301@viscovery.net>
In-Reply-To: <1266996196-25978-7-git-send-email-giuseppe.bilotta@gmail.com>

Giuseppe Bilotta schrieb:
> +	const char *env[local_repo_env_size+2];

Variable sized arrays are prohibited.

>  	struct strbuf buf = STRBUF_INIT;
>  
> +	/* Copy local_repo_env to env, letting i
> +	   rest at the last NULL */
> +	while (env[i] = local_repo_env[i])
> +		++i; /* do nothing */
> +

This looks very inconsistent: At the one hand, you use l_r_e_size to
allocate the space, but then you iterate over it assuming that the list is
(also) NULL-terminated. But this is only a minor nit.

-- Hannes