From: Johannes Sixt <j.sixt@viscovery.net>
Date: Wed, 24 Feb 2010 07:14:05 GMT
Subject: Re: [PATCHv3 2/5] connect: use static list of repo-local env vars
Message-ID: <4B84D1BD.2030908@viscovery.net>
In-Reply-To: <1266968136-11129-3-git-send-email-giuseppe.bilotta@gmail.com>

Giuseppe Bilotta schrieb:
> -		/* remove these from the environment */

You shouldn't remove this comment.

> -		const char *env[] = {
> -			ALTERNATE_DB_ENVIRONMENT,
> -			DB_ENVIRONMENT,
> -			GIT_DIR_ENVIRONMENT,
> -			GIT_WORK_TREE_ENVIRONMENT,
> -			GRAFT_ENVIRONMENT,
> -			INDEX_ENVIRONMENT,
> -			NO_REPLACE_OBJECTS_ENVIRONMENT,
> -			NULL
> -		};
> -		conn->env = env;
> +		conn->env = local_repo_env;

IMO, you should squash this patch and the previous one under the subject
"Move list of repo-local environment variables to a public place", and
that public place could be environment.c instead of a new file cache.c
(the name "cache.c" is definitely wrong).

-- Hannes