From: Johannes Sixt <j.sixt@viscovery.net>
Date: Tue, 23 Feb 2010 06:49:23 GMT
Subject: Re: [PATCH 1/2] shell setup: clear_local_git_env() function
Message-ID: <4B837A73.8010406@viscovery.net>
In-Reply-To: <1266881518-11213-1-git-send-email-giuseppe.bilotta@gmail.com>

Giuseppe Bilotta schrieb:
> +# Clear repo-local GIT_* environment variables. Useful when switching to
> +# another repository (e.g. when entering a submodule)
> +clear_local_git_env() {
> +	unset	GIT_DIR GIT_WORKTREE GIT_OBJECT_DIRECTORY \
> +		GIT_INDEX_FILE GIT_GRAFT_FILE GIT_CONFIG \
> +		GIT_NO_REPLACE_OBJECTS

IMO, this list should be in sync with the one you find in
connect.c:git_connect() around line 611. They have the same purpose.

(And, BTW, a vertical list would be more readable than a mixed
horizontal+vertical list, IMVHO.)

-- Hannes