From: William Pursell <bill.pursell@gmail.com>
Date: Thu, 28 Jan 2010 17:03:45 GMT
Subject: Re: shared permissions on COMMIT_EDITMSG
Message-ID: <4B61C371.4050903@gmail.com>
In-Reply-To: <20100128111425.GA29577@Knoppix>

Ilari Liusvaara wrote:
> On Wed, Jan 27, 2010 at 11:19:22PM -1000, William Pursell wrote:
>> With git-init --shared=0660 and a umask of 022,
>> the first commit to the repository creates
>> the file COMMIT_EDITMSG with mode 0644
>> instead of 0660.  I believe this is incorrect
>> behavior.  Simple fix:
>  
> COMMIT_EDITMSG is related to committing, committing needs
> working copy, and shared working copies don't work all too
> well (and Git can't do anything about that because all kinds
> of stuff edits the files there, not just Git).
> 
> Shared repository settings are meant to override umasks
> for files in actual repository itself.

For simple work flows (eg recording linear history
of config files), sharing a working directory
works okay except for COMMIT_EDITMSG.  Since
COMMIT_EDITMSG is in the git repository and only
written by git, it makes sense for core.sharedrepository
to be honored.

-- 
William Pursell